Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/use Promises #290

Merged
merged 2 commits into from
Mar 27, 2015
Merged

Support/use Promises #290

merged 2 commits into from
Mar 27, 2015

Conversation

raphamorim
Copy link
Contributor

I think that would be a good promises apply. Even for more complex tasks. What do you think?

I started developing locally using bluebird to "promisify" all functions. For now, I just sent half PR, without promises part. If agree, I'll add promises feature.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@vjeux
Copy link
Contributor

vjeux commented Mar 27, 2015

What problem are you trying to solve with promisifying this file?

@raphamorim
Copy link
Contributor Author

Not only this file. I would like to promisify tasks as extractDocs and generate, as would work better without depending on callbacks. What do you think?

@vjeux
Copy link
Contributor

vjeux commented Mar 27, 2015

It's unclear to me what the benefits would be, all the extractDocs methods are synchronous so adding asynchronocity in the mix would only make the code harder to work with.

As for the server itself, it's working fine as is.

It's tempting to go around a codebase and use the latest shiny abstraction but you should only do that to solve problems. If there aren't problems, adding abstraction is a net negative operation

@raphamorim
Copy link
Contributor Author

Gotcha, you're right. Valid only commits to log repair :)

vjeux added a commit that referenced this pull request Mar 27, 2015
@vjeux vjeux merged commit 9c2dbbf into facebook:master Mar 27, 2015
jfrolich pushed a commit to jfrolich/react-native that referenced this pull request Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants